Add support for ingesting multi-night ImageCollections #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewoldag
approved these changes
Oct 22, 2024
Yep! Just did another run to verify after the changes |
drewoldag
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a new multi_night_workflow which ingests ImageCollections with a specified heliocentric guess distance and common WCS.
Here we're pulling a common WCS to resample to from an ImageCollection's "global_wcs" column, and we the heliocentric guess distances for the resampling are specified in the "helio_guess_dists" field in the parsl runtime_config.
Note that the original reprojection task used in other legacy workflows is preserved in
src/kbmod_wf/task_impls/reproject_multi_chip_multi_night_from_uris.pyhowever we may want to consider consolidating/eliminating these older workflows now that we have ways to convert our old URI-based .lst files to standard ImageCollections.Note that while we're reusing the
ic_to_wutask functions for converting the ImageCollection to a WorkUnit, we've combined them into the reprojection step so that we're only loading the WorkUnit when reprojecting it. This means we are also not saving the original WorkUnit to disk since that is expensive and it can be reconstructed from the ImageCollection.